Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usability fix #163

Merged
merged 3 commits into from Aug 19, 2014

Conversation

Projects
None yet
4 participants
@thijsdezoete
Copy link
Contributor

commented Jul 11, 2014

Just show query for all open gerrit requests. I'm open to other suggestions, but I would probably need some help if another suggestion forces me to to touch java stuff. :)

Usability fix
Just show query for all open gerrit requests. I'm open to other suggestions, but I would probably need some help if another suggestion forces me to to touch java stuff. :)
@cloudbees-pull-request-builder

This comment has been minimized.

Copy link

commented Jul 11, 2014

plugins » gerrit-trigger-plugin #296 SUCCESS
This pull request looks good

@jenkinsadmin

This comment has been minimized.

Copy link
Member

commented Jul 11, 2014

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@rsandell

This comment has been minimized.

Copy link
Member

commented Aug 11, 2014

You won't have the previous query displayed correctly in the text field by this change. It will always display "is:open" even though the user types something else.

I guess you're after a "default" text and not the actual value.

@thijsdezoete

This comment has been minimized.

Copy link
Contributor Author

commented Aug 13, 2014

hi @rsandell, yeah I am actually. This was a 5 minute effort to look for this thing and change it, however if you have a better way to do it, please feel free to help me out. I never do java development, so this is all pretty new to me. :)

@rsandell

This comment has been minimized.

Copy link
Member

commented Aug 18, 2014

try to add it to default="status:open" instead of the empty default="" that is there now.

Another approach could be to set the session attribute on page load if it isn't set, but that might lead to unintended behavior.

@thijsdezoete

This comment has been minimized.

Copy link
Contributor Author

commented Aug 18, 2014

@rsandell that'll probably do. 👍 Thanks for the great idea!

@cloudbees-pull-request-builder

This comment has been minimized.

Copy link

commented Aug 18, 2014

plugins » gerrit-trigger-plugin #310 SUCCESS
This pull request looks good

rsandell added a commit that referenced this pull request Aug 19, 2014

@rsandell rsandell merged commit cf6762b into jenkinsci:master Aug 19, 2014

@thijsdezoete

This comment has been minimized.

Copy link
Contributor Author

commented Aug 19, 2014

@rsandell the triggered job now redered unstable, see: https://jenkins.ci.cloudbees.com/job/plugins/job/gerrit-trigger-plugin/311/ what can I do about it?

@rsandell

This comment has been minimized.

Copy link
Member

commented Aug 19, 2014

That looks like a very unrelated error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.