Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include selected labels to review input for REST API #169

Merged
merged 3 commits into from Aug 18, 2014

Conversation

Projects
None yet
4 participants
@rinrinne
Copy link
Member

commented Aug 18, 2014

Message for REST API always includes labels for both code review and
verified. But current Gerrit does not have ones for verified by default.
It causes that review would be denied if label for verified is not added
to gerrit.

This patch can add user selected labels to message for REST API.

Fix for JENKINS-24074

Task-Url: https://issues.jenkins-ci.org/browse/JENKINS-24074

Include selected labels to review input for REST API
Message for REST API always includes labels for both code review and
verified. But current Gerrit does not have ones for verified by default.
It causes that review would be denied if label for verified is not added
to gerrit.

This patch can add user selected labels to message for REST API.

Fix for JENKINS-24074

Task-Url: https://issues.jenkins-ci.org/browse/JENKINS-24074
@cloudbees-pull-request-builder

This comment has been minimized.

Copy link

commented Aug 18, 2014

plugins » gerrit-trigger-plugin #307 UNSTABLE
Looks like there's a problem with this pull request

@cloudbees-pull-request-builder

This comment has been minimized.

Copy link

commented Aug 18, 2014

plugins » gerrit-trigger-plugin #308 SUCCESS
This pull request looks good

@jenkinsadmin

This comment has been minimized.

Copy link
Member

commented Aug 18, 2014

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

rsandell added a commit that referenced this pull request Aug 18, 2014

Merge pull request #169 from rinrinne/rest-review-labels
Include selected labels to review input for REST API

@rsandell rsandell merged commit 83fce44 into jenkinsci:master Aug 18, 2014

@rinrinne rinrinne deleted the rinrinne:rest-review-labels branch Aug 19, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.