Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a trigger for comment containing a specified RegEx #170

Merged

Conversation

Projects
None yet
5 participants
@dopuskh3
Copy link
Contributor

commented Aug 25, 2014

This patch add a trigger that will trigger jenkins build on comment containing
a specified regular expression.

This can be usefull for user to specify a comment to run a build (eg. Please test this )

@cloudbees-pull-request-builder

This comment has been minimized.

Copy link

commented Aug 25, 2014

plugins » gerrit-trigger-plugin #312 FAILURE
Looks like there's a problem with this pull request

@jenkinsadmin

This comment has been minimized.

Copy link
Member

commented Aug 25, 2014

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@dopuskh3 dopuskh3 force-pushed the criteo-forks:comment-contains-regex-feature branch from 1b30f8d to b8fe3c7 Aug 26, 2014

@cloudbees-pull-request-builder

This comment has been minimized.

Copy link

commented Aug 26, 2014

plugins » gerrit-trigger-plugin #313 FAILURE
Looks like there's a problem with this pull request

@rsandell

This comment has been minimized.

Copy link
Member

commented Aug 26, 2014

The build fails because "You have 13 Checkstyle violations".
You should run the test target before upload ;)

@dopuskh3

This comment has been minimized.

Copy link
Contributor Author

commented Aug 26, 2014

Yep sorry. Will fix this.

/*
* The MIT License
*
* Copyright 2012 Sony Mobile Communications AB. All rights reserved.

This comment has been minimized.

Copy link
@rsandell

rsandell Aug 26, 2014

Member

You should specify your own copyright, unless you actually work for Sony Mobile.

This comment has been minimized.

Copy link
@dopuskh3

dopuskh3 Aug 26, 2014

Author Contributor

Fixed thanks

@rsandell

This comment has been minimized.

Copy link
Member

commented Aug 26, 2014

Overall it looks good.

Francois Visconte
Add a trigger for comment containing a specified RegEx
This patch add a trigger that will trigger jenkins build on comment containing
a specified regular expression.

This can be usefull for user to specify a comment to run a build (eg.  Please test this )

@dopuskh3 dopuskh3 force-pushed the criteo-forks:comment-contains-regex-feature branch from b8fe3c7 to a1f4432 Aug 26, 2014

@cloudbees-pull-request-builder

This comment has been minimized.

Copy link

commented Aug 26, 2014

plugins » gerrit-trigger-plugin #314 SUCCESS
This pull request looks good

if (isInteresting(event) && matchesApproval(event)) {
logger.trace("The event is interesting.");
if (isInteresting(event) && commentAddedMatch(event)) {
logger.info("The event is interesting.");

This comment has been minimized.

Copy link
@rsandell

rsandell Aug 26, 2014

Member

Ah, I missed that you had changed the log level. Please change it back to trace as it could spam the log too much on big installations.

This comment has been minimized.

Copy link
@rsandell

rsandell Aug 26, 2014

Member

Never mind, the rest looks good so I can change it after the merge.

rsandell added a commit that referenced this pull request Aug 26, 2014

Merge pull request #170 from criteo/comment-contains-regex-feature
Add a trigger for comment containing a specified RegEx

@rsandell rsandell merged commit 17de86b into jenkinsci:master Aug 26, 2014

@sskotha

This comment has been minimized.

Copy link

commented Apr 7, 2017

I am using the version 2.23.0, is this feature available? I couldn't figure out how to use it, but it would be very useful.

@rsandell

This comment has been minimized.

Copy link
Member

commented Apr 7, 2017

@sskotha This PR was merged on Aug 26, 2014.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.