Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort build completed messages with worst results first #192

Merged
merged 1 commit into from Dec 2, 2014

Conversation

Projects
None yet
3 participants
@chgeo
Copy link
Contributor

commented Nov 28, 2014

So the attention is drawn on the worst results. Otherwise users
may e.g. miss an UNSTABLE result because they see SUCCESS first.

@jenkinsadmin

This comment has been minimized.

Copy link
Member

commented Nov 28, 2014

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@@ -480,7 +531,7 @@ public void tryBuildStatsFailureCommand(String failureMessage, String expectedBu

GerritTrigger trigger = mock(GerritTrigger.class);
when(trigger.getGerritBuildSuccessfulVerifiedValue()).thenReturn(null);
when(trigger.getGerritBuildSuccessfulCodeReviewValue()).thenReturn(32);
when(trigger.getGerritBuildSuccessfulCodeReviewValue()).thenReturn(0);

This comment has been minimized.

Copy link
@rsandell

rsandell Dec 1, 2014

Member

Why this change?

It was a long time ago, but I think the 32 was explicit to make sure that the code review value was actually calculated and not the default int.

This comment has been minimized.

Copy link
@chgeo

chgeo Dec 1, 2014

Author Contributor

It was actually checkstyle that complained about magic numbers. I don't think this specific check makes sense for test code. I there a way to disable it here?

This comment has been minimized.

Copy link
@rsandell

rsandell Dec 1, 2014

Member

Add a line comment somewhere with the following format

//CS IGNORE MagicNumber FOR NEXT 5 LINES. Reason: Test code

The number is how many lines below the comment that the check should be turned off. If you look in many other of the test classes there is one or two at the top of the file spanning something like 200 lines.

Sort build completed messages with worst results first
So the attention is drawn on the worst results.  Otherwise users
may e.g. miss an UNSTABLE result because they see SUCCESS first.

rsandell added a commit that referenced this pull request Dec 2, 2014

Merge pull request #192 from chgeo/messageorder
Sort build completed messages with worst results first

@rsandell rsandell merged commit 19bfb01 into jenkinsci:master Dec 2, 2014

1 check passed

default This pull request looks good
Details

@chgeo chgeo deleted the chgeo:messageorder branch Dec 2, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.