Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gerrit notifier threads should impersonate SYSTEM #202

Merged
merged 1 commit into from Feb 16, 2015

Conversation

@scoheb
Copy link
Contributor

scoheb commented Feb 13, 2015

The BuildCompletedCommandJob was not impersonating SYSTEM and was
therefore throwing permission-related exceptions.

For completeness, BuildStartedCommandJob was updated too.

Related to [JENKINS-23152]

Change-Id: I3eb6036d8186478a615c15036b4b7f98035dd54c

@scoheb scoheb force-pushed the scoheb:impersonating-threads branch from e6f755b to c8795f2 Feb 13, 2015
@jenkinsadmin

This comment has been minimized.

Copy link
Member

jenkinsadmin commented Feb 13, 2015

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

The BuildCompletedCommandJob was not impersonating SYSTEM and was
therefore throwing permission-related exceptions.

For completeness, BuildStartedCommandJob was updated too.

Related to [JENKINS-23152]

Change-Id: I3eb6036d8186478a615c15036b4b7f98035dd54c
@scoheb scoheb force-pushed the scoheb:impersonating-threads branch from c8795f2 to a03c0d5 Feb 13, 2015
rsandell added a commit that referenced this pull request Feb 16, 2015
Gerrit notifier threads should impersonate SYSTEM
@rsandell rsandell merged commit 5512617 into jenkinsci:master Feb 16, 2015
1 check passed
1 check passed
Jenkins This pull request looks good
Details
@rsandell

This comment has been minimized.

Copy link
Member

rsandell commented Feb 16, 2015

will release beta-4 asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.