Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use deprecated DefaultHttpClient #207

Merged
merged 1 commit into from Apr 8, 2015

Conversation

Projects
None yet
3 participants
@dpursehouse
Copy link
Contributor

commented Mar 5, 2015

Change-Id: I73464cae3d5b959e42a2575c4eaa70a178e9cf85

Don't use deprecated DefaultHttpClient
Change-Id: I73464cae3d5b959e42a2575c4eaa70a178e9cf85
@rsandell

This comment has been minimized.

Copy link
Member

commented Mar 5, 2015

Looks OK, just want to hold off merging untill we've figure out how to handle the current -beta release.

@jenkinsadmin

This comment has been minimized.

Copy link
Member

commented Mar 5, 2015

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@dpursehouse

This comment has been minimized.

Copy link
Contributor Author

commented Mar 6, 2015

Looks like this breaks the tests. Hold off on merging this until I've investigated...

@dpursehouse

This comment has been minimized.

Copy link
Contributor Author

commented Mar 6, 2015

Tests are passing locally...

@rsandell

This comment has been minimized.

Copy link
Member

commented Mar 9, 2015

Yes BackCompat252HudsonTest tends to hang every now and then. I haven't manage to fix it and I don't dare to remove it either since it contains some important tests.

@rsandell

This comment has been minimized.

Copy link
Member

commented Mar 9, 2015

👍 But holding off the merge untill We've figure out how to handle the current -beta release

rsandell added a commit that referenced this pull request Apr 8, 2015

Merge pull request #207 from dpursehouse/deprecated-http-client
Don't use deprecated DefaultHttpClient

@rsandell rsandell merged commit 5fd07b8 into jenkinsci:master Apr 8, 2015

1 check failed

Jenkins
Details

@dpursehouse dpursehouse deleted the dpursehouse:deprecated-http-client branch Apr 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.