Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manual trigger: always trigger upon manually triggered build #216

Merged
merged 2 commits into from Apr 8, 2015

Conversation

Projects
None yet
3 participants
@oharboe
Copy link
Contributor

commented Mar 20, 2015

When skip on trivial rebase is enabled, it is useful to manually
retrigger build of patchsets that failed due to an unrelated failure
on the branch that the review is against.

@oharboe oharboe force-pushed the zylin:manualtrigger branch from 1451734 to 74c080e Mar 20, 2015

@oharboe oharboe closed this Mar 20, 2015

@oharboe oharboe reopened this Mar 20, 2015

@jenkinsadmin

This comment has been minimized.

Copy link
Member

commented Mar 20, 2015

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@rsandell

This comment has been minimized.

Copy link
Member

commented Mar 20, 2015

This is a behaviour change in a similar manner to what we are discussing in #215 and it would be good to have a debate on if this should be a forced behaviour or not.

@oharboe oharboe force-pushed the zylin:manualtrigger branch 3 times, most recently from da48747 to 4f695bd Mar 27, 2015

@oharboe oharboe force-pushed the zylin:manualtrigger branch from 4f695bd to caae2a9 Mar 27, 2015

@oharboe oharboe force-pushed the zylin:manualtrigger branch from caae2a9 to 291bf09 Mar 27, 2015

@oharboe oharboe force-pushed the zylin:manualtrigger branch from 291bf09 to 2a405c4 Mar 27, 2015

manual trigger: always trigger upon manually triggered build
When skip on trivial rebase is enabled, it is useful to manually
retrigger build of patchsets.

Before this fix, a retrigger of a skipped build had no effect,
now manually retriggered builds always trigger a build..

@oharboe oharboe force-pushed the zylin:manualtrigger branch from 2a405c4 to d6d0c45 Mar 27, 2015

rsandell added a commit that referenced this pull request Apr 8, 2015

Merge pull request #216 from zylin/manualtrigger
manual trigger: always trigger upon manually triggered build

@rsandell rsandell merged commit 2e5903d into jenkinsci:master Apr 8, 2015

1 check passed

Jenkins This pull request looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.