Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JENKINS-28161 #226

Merged
merged 2 commits into from May 11, 2015

Conversation

Projects
None yet
4 participants
@rsandell
Copy link
Member

commented May 7, 2015

This just fixes the NPE symptoms, but I'm afraid that
the reason that an event has a null value has some deeper issue somewhere.

Fix JENKINS-28161
This just fixes the NPE symptoms, but I'm afraid that
the reason that an event has a null value has some deeper issue somewhere.
@rsandell

This comment has been minimized.

Copy link
Member Author

commented May 7, 2015

@jenkinsadmin

This comment has been minimized.

Copy link
Member

commented May 7, 2015

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@jglick

This comment has been minimized.

Copy link
Member

commented May 7, 2015

BTW please include a meaningful summary of the fix in the PR, and link to the JIRA issue from the description.

if (o1 == null && o2 != null) {
return -1;
}
return new Integer(o1.hashCode()).compareTo(o2.hashCode());

This comment has been minimized.

Copy link
@stephenc

stephenc May 11, 2015

Member

I know this is an aside from the current issue, but comparing events based on a 32 bit integer in order to

This ensures that every event received from Gerrit is kept track of individually

Seems a bit naïve

@stephenc

This comment has been minimized.

Copy link
Member

commented May 11, 2015

👍 on making more stable

rsandell added a commit that referenced this pull request May 11, 2015

@rsandell rsandell merged commit 4ffe3ac into master May 11, 2015

1 check passed

Jenkins This pull request looks good
Details

@rsandell rsandell deleted the JENKINS-28161 branch May 11, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.