Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Unreviewed Patches feature #228

Merged
merged 1 commit into from May 18, 2015

Conversation

Projects
None yet
3 participants
@scoheb
Copy link
Contributor

commented May 12, 2015

This is replaced by the Missed Event Playback Manager feature

@jenkinsadmin

This comment has been minimized.

Copy link
Member

commented May 12, 2015

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@@ -182,11 +182,6 @@
<f:checkbox name="silentMode"
checked="${it.silentMode}"/>
</f:entry>
<f:entry title="${%Check Non-Reviewed Patchsets}"
field="allowTriggeringUnreviewedPatches"

This comment has been minimized.

Copy link
@rsandell

rsandell May 13, 2015

Member

You should also deprecate the field and make it transient in GerritTrigger.java

Remove Unreviewed Patches feature
This is replaced by the Missed Event Playback Manager feature

Change-Id: Iacd43f545739235faccd12fd28cc5c83b9400542

@scoheb scoheb force-pushed the scoheb:remove-unreviewed-listener-2.14 branch from 7cc3064 to 5ee8b17 May 15, 2015

rsandell added a commit that referenced this pull request May 18, 2015

@rsandell rsandell merged commit bcacb31 into jenkinsci:master May 18, 2015

1 check passed

Jenkins This pull request looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.