This is the line that was causing a warning. The allowTriggeringUnreviewedPatches on the right hand side of the assignment is not a constructor argument like the others, so it resolves to the class member and is just assigning the same member variable to itself.
As mentioned by @rsandell in review, removing the member variable
in commit d90eb78 will break loading of old configs.
Put it back, and instead of assigning it to itself, just assign
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.