Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Findbugs cleanup #244

Merged
merged 7 commits into from Sep 1, 2015

Conversation

Projects
None yet
3 participants
@dpursehouse
Copy link
Contributor

commented Sep 1, 2015

No description provided.

dpursehouse added some commits Sep 1, 2015

GerritTriggerParameters: Be more specific in exception catching
Change-Id: Id5f566c350b1eee943daa30ffdea11b576cff8d6
GerritDynamicUrlProcessor: Use StringBuilder to concatenate strings i…
…n a loop

Change-Id: I92f5c07e374596d50c8a4a463a444ee123baec64
Upgrade Findbugs Maven plugin to 3.0.2
Change-Id: I6e37538bfd9bab169a357a15af5f9dc5d5b928a8
Use `Integer.valueOf(int)` instead of `new Integer(int)`
Change-Id: Ib5c5612b011945434ac9065e88bc0500f122e20c
GerritMissedEventsPlaybackManager: Fix potential null pointer access
The getEventsFromEventsLogPlugin method was potentially dereferencing
a null HttpEntity.  Move it inside a null-check.

Also remove duplicate warning logs.

Change-Id: I4556cc0f7cefec3cf9d79459bb1cb0bb675b888d
Use explicit UTF-8 charset instead of relying on system default
Change-Id: I5470956a13fd309586e3487f825fded5b766fd7f
@@ -40,6 +40,7 @@
import java.net.MalformedURLException;
import java.net.URL;
import java.net.URLConnection;
import java.nio.charset.StandardCharsets;

This comment has been minimized.

Copy link
@rsandell

rsandell Sep 1, 2015

Member

This class is Java 1.7, but this plugin is still based on a Jenkins core version that supports Java 1.6. So until we go >=1.612 of Jenkins core we shouldn't use Java 1.7 features.

This comment has been minimized.

Copy link
@dpursehouse

dpursehouse Sep 1, 2015

Author Contributor

Done in 0b44bfc

@rsandell

This comment has been minimized.

Copy link
Member

commented Sep 1, 2015

The build failure was because of BackCompat252HudsonTest being flaky and hanging as usual.

Use java.nio.charset.Charset instead of java.nio.charset.StandardChar…
…sets

java.nio.charset.StandardCharsets is from Java 1.7, but the plugin
is currently built against a version of core Jenkins that only
supports Java 1.6

Change-Id: If8dda4b416e84e5cf29dfb3f7f6e96a0dd39177b
@jenkinsadmin

This comment has been minimized.

Copy link
Member

commented Sep 1, 2015

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

rsandell added a commit that referenced this pull request Sep 1, 2015

@rsandell rsandell merged commit d049d4e into jenkinsci:master Sep 1, 2015

1 check failed

Jenkins
Details

@dpursehouse dpursehouse deleted the dpursehouse:findbugs-cleanup branch Sep 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.