Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Gerrit Events 2.9.1 #249

Merged
merged 1 commit into from Sep 13, 2015

Conversation

Projects
None yet
3 participants
@scoheb
Copy link
Contributor

commented Sep 9, 2015

Added Backwards compatibilty tests for updated RefUpdated event in Gerrit 2.12

Change-Id: I0ec50bf1ea146c254046d093801052b17e58eebb

Scott Hebert
Upgrade to Gerrit Events 2.9.1
Added Backwards compatibilty tests for updated RefUpdated event in Gerrit 2.12

Change-Id: I0ec50bf1ea146c254046d093801052b17e58eebb
@jenkinsadmin

This comment has been minimized.

Copy link
Member

commented Sep 9, 2015

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

trigger.setGerritProjects(Collections.nCopies(1, gP));
trigger.setEscapeQuotes(false);
trigger.setSilentMode(false);
Whitebox.setInternalState(trigger, "job", project);

This comment has been minimized.

Copy link
@rsandell

rsandell Sep 10, 2015

Member

Is this really needed since Setup.createRefUpdatedTrigger(project) calls trigger.start(project)?

This comment has been minimized.

Copy link
@scoheb

scoheb Sep 11, 2015

Author Contributor

I needed to be able to specify the PLAIN matcher to properly test the change in ref name behaviour.

Is there another way?

This comment has been minimized.

Copy link
@rsandell

rsandell Sep 13, 2015

Member

this line is in essence trigger.job = project; so I don't think that has anything to do with the plain matcher?

@rsandell

This comment has been minimized.

Copy link
Member

commented Sep 10, 2015

As I mentioned in #241 I'll need some help in verifying that the new HttpClient code works in a standalone jenkins before I dare to merge this in.

@scoheb

This comment has been minimized.

Copy link
Contributor Author

commented Sep 10, 2015

I can help...just give me some pointers and/or scenarios to test

@rsandell

This comment has been minimized.

Copy link
Member

commented Sep 10, 2015

Just a standalone jenkins.war with GT configured to use the REST API should do.
My concern is that the commons.httpclient lib has different versions in gerrit-events than jenkins core and that those libs might be loaded in the wrong order and you'd get a CNF or AbstractMethodError when using it.

@scoheb

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2015

Hi,

Attached are some images depicting the successful testing of Gerrit Trigger 2.15.1-SNAPSHOT using Gerrit Events 2.9.1

Plugin Version
gt-2 15 1-snapshot-pluginversion

REST API enabled
gt-2 15 1-snapshot-restapi

Notifications sent to Gerrit
gt-2 15 1-snapshot-gerrithistory

In addition, I made sure to use different users for the SSH connection and the REST API connection to validate the notification.

rsandell added a commit that referenced this pull request Sep 13, 2015

Merge pull request #249 from scoheb/gerrit-events-291
Upgrade to Gerrit Events 2.9.1 to fix backwards compatibility of RefUpdated event in Gerrit 2.12

@rsandell rsandell merged commit 8e425a4 into jenkinsci:master Sep 13, 2015

1 check passed

Jenkins This pull request looks good
Details
@scoheb

This comment has been minimized.

Copy link
Contributor Author

commented Sep 14, 2015

What are your plans for creating 2.15.1? Tx

@rsandell

This comment has been minimized.

Copy link
Member

commented Sep 14, 2015

@svanoort has a fix in 2.9.2 of gerrit-events, when that's in the plugin I'll make a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.