Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for change to Gerrit stream events #253

Merged
merged 1 commit into from Oct 8, 2015

Conversation

Projects
None yet
3 participants
@zaro0508
Copy link
Member

commented Oct 6, 2015

A pending Gerrit stream events change[1] will append approval info
to every comment-added event. That change also adds an updated
attribute to the approvals info. This change will ensure that the label
trigger will continue to work with existing Gerrit versions and with the
upcoming stream events change in newer Gerrit versions.

This change dependings on a pending gerrit-events update[2]

[1] https://gerrit-review.googlesource.com/#/c/71051
[2] sonyxperiadev/gerrit-events#48

Update for change to Gerrit stream events
A pending Gerrit stream events change[1] will append approval info
to every comment-added event.  That change also adds an `updated`
attribute to the approvals info.  This change will ensure that the label
trigger will continue to work with existing Gerrit versions and with the
upcoming stream events change in newer Gerrit versions.

This change dependings on a pending gerrit-events update[2]

[1] https://gerrit-review.googlesource.com/#/c/71051
[2] sonyxperiadev/gerrit-events#48
@jenkinsadmin

This comment has been minimized.

Copy link
Member

commented Oct 7, 2015

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@rsandell

This comment has been minimized.

Copy link
Member

commented Oct 7, 2015

👍 looks good. I'm just going to look over that Java 7 issue in gerrit-events and make a new release.
Depending on how I fix it it might result in a different version number than predicted in this change.

@rsandell

This comment has been minimized.

Copy link
Member

commented Oct 8, 2015

Just tickling the GH pull request builder to try again

@rsandell rsandell closed this Oct 8, 2015

@rsandell rsandell reopened this Oct 8, 2015

rsandell added a commit that referenced this pull request Oct 8, 2015

Merge pull request #253 from zaro0508/update-trigger
Update for Approval.updated change to Gerrit stream events

@rsandell rsandell merged commit d0541c8 into jenkinsci:master Oct 8, 2015

1 check passed

Jenkins This pull request looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.