Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Missed Events Playback manager init #259

Merged
merged 1 commit into from Nov 26, 2015

Conversation

Projects
None yet
2 participants
@scoheb
Copy link
Contributor

commented Nov 25, 2015

It is possible for the Missed Events playback manager to not be correctly initialized
once the REST API has been enabled AFTER the connection has been started.

The same issue applies if the Gerrit events-log plugin was installed AFTER the
Gerrit connection was started.

This ensures that the listener is active so that playback can execute when required.

[FIXED JENKINS-31439]

Scott Hebert
Correct Missed Events Playback manager init
It is possible for the Missed Events playback manager to not be correctly initialized
once the REST API has been enabled AFTER the connection has been started.

The same issue applies if the Gerrit events-log plugin was installed AFTER the
Gerrit connection was started.

This ensures that the listener is active so that playback can execute when required.

[FIXED JENKINS-31439]

rsandell added a commit that referenced this pull request Nov 26, 2015

Merge pull request #259 from scoheb/playback-fix
Correct Missed Events Playback manager init

@rsandell rsandell merged commit 79a7af5 into jenkinsci:master Nov 26, 2015

1 check passed

Jenkins This pull request looks good
Details
@rsandell

This comment has been minimized.

Copy link
Member

commented Nov 26, 2015

Should I release this fix directly or can it wait for #258 ?

@scoheb

This comment has been minimized.

Copy link
Contributor Author

commented Nov 26, 2015

Since it is a bug fix, it would be nice if it could be released now.

Tx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.