Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project list is not updating in desired interval #260

Merged
merged 1 commit into from Nov 27, 2015

Conversation

Projects
None yet
2 participants
@scoheb
Copy link
Contributor

commented Nov 27, 2015

Fix bug whereby project list updating was not active upon connection startup.

Only applies for Gerrit servers < 2.12.

[FIXED JENKINS-31473]

@@ -140,6 +138,10 @@ public synchronized void shutdown() {

@Override
public void run() {
//Ensure connected
while (!connected) {

This comment has been minimized.

Copy link
@rsandell

rsandell Nov 27, 2015

Member

It might be safer to make connected an AtomicBoolean

This comment has been minimized.

Copy link
@scoheb

scoheb Nov 27, 2015

Author Contributor

will do


import org.apache.http.auth.Credentials;

/**

This comment has been minimized.

Copy link
@rsandell

rsandell Nov 27, 2015

Member

Would it be possible to just extend whatever class you copied this from and override the particular values that you need? It seems a bit ugly/unnecessary to bloat the tests like this.

This comment has been minimized.

Copy link
@scoheb

scoheb Nov 27, 2015

Author Contributor

will do

@scoheb

This comment has been minimized.

Copy link
Contributor Author

commented Nov 27, 2015

Seems like the build is hanging on a test. Could you please abort it? I will debug it.

@rsandell

This comment has been minimized.

Copy link
Member

commented Nov 27, 2015

It didn't hang on the standard backcompat tests at least :)

Scott Hebert
Project list is not updating in desired interval
Fix bug whereby project list updating was not active upon connection startup.

Only applies for Gerrit servers < 2.12.

[FIXED JENKINS-31473]

@scoheb scoheb force-pushed the scoheb:project-list-fix branch from d4a6111 to f3b31e3 Nov 27, 2015

@scoheb

This comment has been minimized.

Copy link
Contributor Author

commented Nov 27, 2015

I have another PR on its way for another bug. So this PR can be rolled into your next planned release at your convenience!

rsandell added a commit that referenced this pull request Nov 27, 2015

Merge pull request #260 from scoheb/project-list-fix
Project list is not updating in desired interval

@rsandell rsandell merged commit 921e93f into jenkinsci:master Nov 27, 2015

1 check passed

Jenkins This pull request looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.