Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added configurable parameter mode for GERRIT_CHANGE_SUBJECT #265

Merged
merged 6 commits into from Dec 1, 2015

Conversation

Projects
None yet
4 participants
@rsandell
Copy link
Member

commented Nov 30, 2015

@reviewbybees

This comment has been minimized.

Copy link

commented Nov 30, 2015

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

rsandell added some commits Nov 30, 2015

Only print the parameters in the test ParameterBuilder
Since jenkins test harness is populating the builds with the environment
of the process the pull request subject was also added to the unit test build.
That caused one of the tests to fail because it was looking for the absence of a
parameter name that was present in the pull request title.
Changing the test builder to only print the parameters should solve it.
@Vlatombe

This comment has been minimized.

Copy link
Member

commented Dec 1, 2015

🐝

@oleg-nenashev

This comment has been minimized.

Copy link
Member

commented Dec 1, 2015

🐝 from what I see

rsandell added a commit that referenced this pull request Dec 1, 2015

Merge pull request #265 from jenkinsci/nosubject
Added configurable parameter mode for GERRIT_CHANGE_SUBJECT

@rsandell rsandell merged commit fadfd94 into master Dec 1, 2015

1 check passed

Jenkins This pull request looks good
Details

@rsandell rsandell deleted the nosubject branch Dec 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.