Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename category deprecated default names CRVW and VRIF #270

Merged
merged 1 commit into from Dec 3, 2015

Conversation

Projects
None yet
2 participants
@engycz
Copy link
Contributor

commented Dec 3, 2015

Rename category deprecated default names CRVW and VRIF
removed in Gerrit 2.6 (2 years old) to current
label names Code-Review and Verified

Default values concerns only to newly created servers in gerrit trigger. Copied servers also copies verdict categories from the parent. So this change is mainly for new Jenkins users with >= 2.6 Gerrit server.
CRVW and VRIF were used last time in Gerrit 2.5.6

Sorry for new pull request (previous was #269). I was pushed my new master and #269 was closed.

Merge as you wish, it is not a bug.

Rename category deprecated default names CRVW and VRIF
removed in Gerrit 2.6 (2 years old) to current
label names Code-Review and Verified
@rsandell

This comment has been minimized.

Copy link
Member

commented Dec 3, 2015

Well it's technically a bugfix for ManualTriggerAction :) at least for newer Gerrit servers.

rsandell added a commit that referenced this pull request Dec 3, 2015

Merge pull request #270 from engycz/verdict_category
Rename category deprecated default names CRVW and VRIF

@rsandell rsandell merged commit 986e00f into jenkinsci:master Dec 3, 2015

1 check passed

Jenkins This pull request looks good
Details

@engycz engycz deleted the engycz:verdict_category branch Dec 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.