Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix projectListRefreshInterval zero value after upgrade from 2.13.0 to 2.14.0 #273

Merged
merged 1 commit into from Jan 5, 2016

Conversation

Projects
None yet
3 participants
@engycz
Copy link
Contributor

commented Dec 22, 2015

Fix projectListRefreshInterval zero value after upgrade from 2.13.0 to 2.14.0

[FIXED JENKINS-31800]

@engycz engycz force-pushed the engycz:JENKINS-31800 branch from fa486a5 to dbae46f Dec 22, 2015

@jenkinsadmin

This comment has been minimized.

Copy link
Member

commented Dec 28, 2015

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.

@@ -263,7 +263,7 @@
<f:textbox name="projectListRefreshInterval"
value="${it.config.projectListRefreshInterval}"
default="${com.sonyericsson.gerrithudsontrigger.config.Config.DEFAULT_PROJECT_LIST_REFRESH_INTERVAL}"
checkUrl="'${rootURL}/${serverURL}/projectListFetchDelayCheck?value='+escape(this.value)"
checkUrl="'${rootURL}/${serverURL}/positiveIntegerCheck?value='+escape(this.value)"

This comment has been minimized.

Copy link
@rsandell

rsandell Jan 5, 2016

Member

GerritServer.DescriptorImpl.doProjectListFetchDelayCheck() should be removed if we don't plan to use it any more which it seems like.

This comment has been minimized.

Copy link
@engycz

engycz Jan 5, 2016

Author Contributor

Done

@rsandell

This comment has been minimized.

Copy link
Member

commented Jan 5, 2016

Back from vacation, sorry for the delay in review.

@engycz engycz force-pushed the engycz:JENKINS-31800 branch from dbae46f to 78f4c5c Jan 5, 2016

rsandell added a commit that referenced this pull request Jan 5, 2016

Merge pull request #273 from engycz/JENKINS-31800
Fix projectListRefreshInterval zero value after upgrade from 2.13.0 to 2.14.0

@rsandell rsandell merged commit ba1c6cb into jenkinsci:master Jan 5, 2016

1 check passed

Jenkins This pull request looks good
Details

@engycz engycz deleted the engycz:JENKINS-31800 branch Jan 8, 2016

@engycz engycz restored the engycz:JENKINS-31800 branch Jan 8, 2016

@engycz engycz deleted the engycz:JENKINS-31800 branch Jan 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.