Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't used ReflectiveOperationException #276

Merged
merged 1 commit into from Mar 8, 2016

Conversation

Projects
None yet
2 participants
@dpursehouse
Copy link
Contributor

commented Mar 8, 2016

Using ReflectiveOperationException breaks Java 6 runtime compatibility.

[FIXED JENKINS-30857]

Change-Id: Ic8c88102cf9ef3a3286f5311d1b3ed661ac2d77c

Don't used ReflectiveOperationException
Using ReflectiveOperationException breaks Java 6 runtime compatibility.

[FIXED JENKINS-30857]

Change-Id: Ic8c88102cf9ef3a3286f5311d1b3ed661ac2d77c
@dpursehouse

This comment has been minimized.

Copy link
Contributor Author

commented Mar 8, 2016

@rsandell it seems I broke Java6 compatibility with one of my patches last year, and I only found out about it today :(

rsandell added a commit that referenced this pull request Mar 8, 2016

Merge pull request #276 from dpursehouse/JENKINS-30857
Don't used ReflectiveOperationException

@rsandell rsandell merged commit b52fd7d into jenkinsci:master Mar 8, 2016

1 check passed

Jenkins This pull request looks good
Details
@rsandell

This comment has been minimized.

Copy link
Member

commented Mar 8, 2016

@dpursehouse Yes, maybe we should add an animal-sniffer config in the pom just as I did in gerrit-events to avoid this in the future?

@dpursehouse

This comment has been minimized.

Copy link
Contributor Author

commented Mar 8, 2016

@rsandell done, see PR #277.

@dpursehouse dpursehouse deleted the dpursehouse:JENKINS-30857 branch Mar 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.