Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trigger for changes to Gerrit comment-added stream event #279

Merged
merged 1 commit into from Apr 12, 2016

Conversation

Projects
None yet
3 participants
@zaro0508
Copy link
Member

commented Apr 4, 2016

This is a redo of change 406ae59. More info can be found in
the dependent gerrit-events pull request[1]. In summary
the Gerrit change[2] that initially planned on adding an
updated flag for approvals ended up adding an oldValue
property instead.

[1] sonyxperiadev/gerrit-events#51
[2] https://gerrit-review.googlesource.com/#/c/71051

Fix trigger for changes to Gerrit comment-added stream event
This is a redo of change 406ae59.  More info can be found in
the dependent gerrit-events pull request[1].  In summary
the Gerrit change[2] that initially planned on adding an
`updated` flag for approvals ended up adding an `oldValue`
property instead.

[1] sonyxperiadev/gerrit-events#51
[2] https://gerrit-review.googlesource.com/#/c/71051
@jenkinsadmin

This comment has been minimized.

Copy link
Member

commented Apr 5, 2016

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.

@rsandell

This comment has been minimized.

Copy link
Member

commented Apr 11, 2016

gerrit-events 2.9.5 is now released, we should tickle the PR builder when it has fully propagated to Maven central.

@rsandell rsandell closed this Apr 12, 2016

@rsandell

This comment has been minimized.

Copy link
Member

commented Apr 12, 2016

Just tickling the PR builder...

@rsandell rsandell reopened this Apr 12, 2016

@rsandell rsandell merged commit c642d06 into jenkinsci:master Apr 12, 2016

1 check passed

Jenkins This pull request looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.