Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent double HTML escaping of subject in search results #304

Merged
merged 1 commit into from Jan 12, 2017

Conversation

Projects
None yet
2 participants
@jbesta
Copy link

commented Jan 12, 2017

Characters like " in commit message are not properly displayed on search page - " is rendered Instead of ".

Jindrich Besta
Prevent double HTML escaping of subject
There's no need to manually escape contents of subject.
Jelly already does it with: <?jelly escape-by-default='true'?>

Change-Id: I9bd8b5fa7307a9408dedb181fda3790104652f8c
@rsandell

This comment has been minimized.

Copy link
Member

commented Jan 12, 2017

Yepp, seems like something we missed when adding <?jelly escape-by-default='true'?> to index.jelly

@rsandell rsandell merged commit a7541de into jenkinsci:master Jan 12, 2017

1 check passed

Jenkins This pull request looks good
Details

@jbesta jbesta deleted the jbesta:fix_rendering branch Jan 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.