Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display full commit message in tooltip #306

Merged
merged 2 commits into from Jan 20, 2017

Conversation

Projects
None yet
2 participants
@jbesta
Copy link

commented Jan 18, 2017

On Gerrit Manual Trigger page, "only" commit message header
(first 65 characters of commit message) is displayed in Subject
column.
This change modifies it such that when user hovers over change
subject, native tooltip with full commit message is displayed.
This should provide additional information about a change.

Jindrich Besta
Display full commit message in tooltip
On *Gerrit Manual Trigger* page, "only" commit message header
(first 65 characters of commit message) is displayed in `Subject`
column.
This change modifies it such that when user hovers over change
subject, native tooltip with full commit message is displayed.
This should provide additional information about a change.

Change-Id: I50bf6fda17b1e945fb76b305c3049888c722eec6
Signed-Off-By: Jindrich Besta <jindrich@amarulasolutions.com>
Jira-Id: ISUP-111
@rsandell

This comment has been minimized.

Copy link
Member

commented Jan 19, 2017

When did commitMessage start to appear in the search result? Mostly wondering so that users of older Gerrit versions won't get a JSONException when visiting the page.

@jbesta

This comment has been minimized.

Copy link
Author

commented Jan 20, 2017

I can't find in gerrit changelogs exact version which introduced this field, however, the feature was implemented on Gerrit server already in 10/2011 according to this commit gerrit-review/gerrit@0943d6e.

Anyway, gerrit query command documentation page (https://review.openstack.org/Documentation/cmd-query.html) states:

Note that any field may be missing in the JSON messages, so consumers of this JSON stream should deal with that appropriately.

so I think we should add additional existence check for commitMessage field in JSON.

Jindrich Besta
Render `commitMessage` in title attribute only if it exists in JSON
[`gerrit query` command documentation](https://review.openstack.org/Documentation/cmd-query.html) page states:

> Note that any field may be missing in the JSON messages, so consumers of this
> JSON stream should deal with that appropriately.

so we additionally check if `commitMessage` field is present in JSON response.

Change-Id: I970326b8cb41294fe6dedeeb88e1e4f249575c64
Signed-off-by: Jindrich Besta <jindrich@amarulasolutions.com>
@rsandell

This comment has been minimized.

Copy link
Member

commented Jan 20, 2017

opt or optString could also work.

@rsandell rsandell merged commit b0b2c86 into jenkinsci:master Jan 20, 2017

1 check passed

Jenkins This pull request looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.