Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CommentAdded event for Gerrit snapshot version < 2.13 #310

Merged
merged 1 commit into from Apr 19, 2017

Conversation

Projects
None yet
2 participants
@hugares
Copy link
Member

commented Apr 18, 2017

0a8e1c2 adapted CommentAdded event firing for Gerrit version >= 2.13
and backward compatibility is kept for Gerrit version < 2.13.

The version check done to maintain backward compatibility was not
excluding snapshot so snapshot versions that are < 2.13 were handling
CommentAdded event the way they are supposed to be for Gerrit >= 2.13.

Fix CommentAdded event for Gerrit snapshot version < 2.13
0a8e1c2 adapted CommentAdded event firing for Gerrit version >= 2.13
and backward compatibility is kept for Gerrit version < 2.13.

The version check done to maintain backward compatibility was not
excluding snapshot so snapshot versions that are < 2.13 were handling
CommentAdded event the way they are supposed to be for Gerrit >= 2.13.

@rsandell rsandell merged commit 51907db into jenkinsci:master Apr 19, 2017

1 check passed

Jenkins This pull request looks good
Details
@hugares

This comment has been minimized.

Copy link
Member Author

commented Apr 19, 2017

@rsandell When do you plan to release 2.23.2? I am asking because we do not centrally managed our Jenkins instances so people can install 2.23.1 anytime and hit the regression that this PR is fixing.

@rsandell

This comment has been minimized.

Copy link
Member

commented Apr 19, 2017

@hugares The release finished at: 2017-04-19T13:08:26+02:00 during my lunch break :)

@hugares

This comment has been minimized.

Copy link
Member Author

commented Apr 19, 2017

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.