Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-39010] CommentAddedRegex: Input is a multiline message #312

Merged
merged 1 commit into from May 10, 2017

Conversation

Projects
None yet
2 participants
@bpedersen2
Copy link

commented May 10, 2017

Interpret the incoming comment message as multi-line text, as gerrit
prefixes some heading to the input.

Add debug logging as well.

Fixes: JENKINS-39010

CommentAddedRegex: Input is a multiline message
Intrept the incoming comment message as multi-line text, as gerrit
prefixes some heading to the input.

Add debug logging as well.

Fixes: #39010

@rsandell rsandell changed the title CommentAddedRegex: Input is a multiline message [JENKINS-39010] CommentAddedRegex: Input is a multiline message May 10, 2017

@rsandell rsandell merged commit 25b4597 into jenkinsci:master May 10, 2017

1 check passed

Jenkins This pull request looks good
Details
@rsandell

This comment has been minimized.

Copy link
Member

commented May 10, 2017

Thanks!
Please provide unit tests next time.

@bpedersen2

This comment has been minimized.

Copy link
Author

commented May 10, 2017

Thanks for merging. I actually looked at providin ga test, but as I found now suitable test to derive from , I ahd to give up (I normally just do python programming, so writing a java test from scratch is quite time consuming for me)

@bpedersen2 bpedersen2 deleted the bpedersen2:39010 branch May 10, 2017

@rsandell

This comment has been minimized.

Copy link
Member

commented May 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.