Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GerritDynamicUrlProcessor: fix slf4j notation #315

Merged
merged 1 commit into from Jun 9, 2017

Conversation

Projects
None yet
4 participants
@alonbl
Copy link
Contributor

commented May 24, 2017

Signed-off-by: Alon Bar-Lev alon.barlev@gmail.com

@@ -180,7 +180,7 @@ private static String regexEscapted(char symbol) {
char operChar = oper.charAt(0);
CompareType type = CompareType.findByOperator(operChar);

logger.trace("==> item:({0}) oper:({1}) text:({2})", new Object[]{item, oper, text});
logger.trace("==> item:({}) oper:({}) text:({})", new Object[]{item, oper, text});

This comment has been minimized.

Copy link
@hugares

hugares May 31, 2017

Member

I think you can remove the object array as well:
logger.trace("==> item:({}) oper:({}) text:({})", item, oper, text);

This comment has been minimized.

Copy link
@alonbl

alonbl May 31, 2017

Author Contributor

Correct! Fixed.

This comment has been minimized.

Copy link
@rsandell

rsandell Jun 9, 2017

Member

I don't see the fix

This comment has been minimized.

Copy link
@alonbl

alonbl Jun 9, 2017

Author Contributor

we are using too old slf4j, I had to revert this as the slf4j does not support ...

the important fix is not to use {n}.

This comment has been minimized.

Copy link
@rsandell

rsandell Jun 9, 2017

Member

Yea, I see that now. Strange, we should perhaps look into bumping slf4j to a newer version but that might put us in a bit of trouble since core is also bundling a version of slf4j that might conflict.

GerritDynamicUrlProcessor: fix slf4j notation
Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>

@rsandell rsandell merged commit bf283c8 into jenkinsci:master Jun 9, 2017

1 check passed

Jenkins This pull request looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.