Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sending multiline comments #316

Merged
merged 1 commit into from Aug 4, 2017

Conversation

Projects
None yet
2 participants
@lorenzph
Copy link
Contributor

commented May 28, 2017

While Gerrit's API supports multiline review comments the Gerrit Trigger
UI limits the user to single line inputs. Improve this by using a
textarea widget instead.

@rsandell
Copy link
Member

left a comment

Please add tests to verify this works

Support sending multiline comments
While Gerrit's API supports multiline review comments the Gerrit Trigger
UI limits the user to single line inputs. Improve this by using a
textarea widget instead.

@lorenzph lorenzph force-pushed the lorenzph:support-multiline-comments branch from bd562ce to c28bb56 Jul 3, 2017

@lorenzph

This comment has been minimized.

Copy link
Contributor Author

commented Jul 3, 2017

@rsandell: I have added a test that verifies that the ParameterExpander correctly handles newlines within the command template. I am not sure how else this UI only change can be tested (essentially the same thing can be accomplished by editing the plugin configuration file but editing the config via the UI ends up removing the newlines as the browser discards the newlines from the textboxes).

Let me know if you have any further suggestions on how to test this.

@rsandell rsandell merged commit f7d6614 into jenkinsci:master Aug 4, 2017

@rsandell

This comment has been minimized.

Copy link
Member

commented Aug 4, 2017

Well I was hoping for to have a test that actually sends a message with a new line in it, so that we know the default command line works with a newline in the message. It does not only affect the UI since it will now be able to send back message strings to the command. And that is what I need to know works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.