Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX JENKINS-39132] No comments to Gerrit 2.13.1 for Change Merged trigger #330

Merged
merged 1 commit into from Oct 12, 2017

Conversation

Projects
None yet
4 participants
@Jimilian
Copy link
Contributor

commented Oct 10, 2017

I'm not aware about all possible use cases, but removing --code-review null and --verified null in case of memoryImprint.getEvent().isScorable() == false does the fix (ParameterExpander.java:280).

@Jimilian Jimilian force-pushed the Jimilian:JENKINS_39132 branch from fe554f7 to 48e0ddc Oct 10, 2017

@rsandell rsandell merged commit c24533f into jenkinsci:master Oct 12, 2017

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details

@Jimilian Jimilian deleted the Jimilian:JENKINS_39132 branch Oct 17, 2017

@Jimilian

This comment has been minimized.

Copy link
Contributor Author

commented Oct 17, 2017

@oleg-nenashev

This comment has been minimized.

Copy link
Member

commented Oct 17, 2017

@Jimilian added the label for both PRs

@engycz

This comment has been minimized.

Copy link
Contributor

commented Dec 7, 2017

Not working for custom label names such as
gerrit review <CHANGE>,<PATCHSET> --message 'Build Successful <BUILDS_STATS>' --label Build-check=<VERIFIED> --code-review <CODE_REVIEW>

The command issued to Gerrit looks like
[2017-12-07 13:12:24,180 +0100] 1de0b61a jenkins a/4 gerrit.review.144,1.--message.Build Successful https://xxxxx/jenkins/job/test/96/ : SUCCESS.--label.Build-check=null 2ms 9ms 1

@Jimilian

This comment has been minimized.

Copy link
Contributor Author

commented Dec 7, 2017

@engycz Any ideas how to fix it in reliable way? Potentially we can remove anything that has format KEY=VALUE (if VALUE is integer)

@engycz

This comment has been minimized.

Copy link
Contributor

commented Dec 7, 2017

I suggest to remove anything with format --label KEY=VALUE. --code-review and --verified are somehow removed today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.