Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not query Jenkins Core API if it's possible #332

Merged

Conversation

Projects
None yet
2 participants
@Jimilian
Copy link
Contributor

commented Oct 25, 2017

Entity.getProject uses Jenkins Core API to get the instance of Job. As result
it leads to big memory footprint because getItemByFullName needs to pass
ACL checks.

screen shot 2017-10-25 at 14 49 33

Do not query Jenkins Core API if it's possible
getProject uses Jenkins Core API to get the instance of Job. As result
it leads to big memory footprint because getItemByFullname needs to pass
ACL checks.
@rsandell
Copy link
Member

left a comment

Hmm,
But if the current user is SYSTEM then the ACL check should get short circuit'ed. So it's strange that the impact is big.

@rsandell rsandell merged commit fe5e265 into jenkinsci:master Oct 25, 2017

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
@Jimilian

This comment has been minimized.

Copy link
Contributor Author

commented Oct 25, 2017

@rsandell thanks for unbelievable speed :)

Unfortunately, Matrix Authorization Strategy Plugin does not have this short cut. I will feel the PR for that tomorrow, probably. Plus, I'm not sure that it's always SYSTEM user. At least it's not forced through context.

@Jimilian Jimilian deleted the Jimilian:reduce_memory_consumption_get_project branch Oct 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.