Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly provide GerritTrigger object to `schedule` method #334

Merged
merged 1 commit into from Dec 1, 2017

Conversation

Projects
None yet
2 participants
@Jimilian
Copy link
Contributor

commented Nov 20, 2017

Before it was possible to hit the race condtion during Jenkins
initalization: GerritTrigger was already completely initialized, but Job
object was still "under construction". As result
calculateDynamicConfigRefreshInterval did a fallback to Average
interval. Unfortnately, the list of server could be non-initilized as
well. That leads to using MINIMUM_DYNAMIC_CONFIG_REFRESH_INTERVAL
instead of specified one.

Explicitly provide GerritTrigger object to `schedule` method
Before it was possible to hit the race condtion during Jenkins
initalization: GerritTrigger was already completely initialized, but Job
object was still "under construction". As result
`calculateDynamicConfigRefreshInterval` did a fallback to Average
interval. Unfortnately, the list of server could be non-initilized as
well. That leads to using `MINIMUM_DYNAMIC_CONFIG_REFRESH_INTERVAL`
instead of specified one.
@Jimilian

This comment has been minimized.

Copy link
Contributor Author

commented Nov 29, 2017

@rsandell can you take a look please?

@rsandell

This comment has been minimized.

Copy link
Member

commented Dec 1, 2017

Sorry, I've been very busy for a while. Trying to catch up on reviews :)

@rsandell rsandell merged commit d7826cd into jenkinsci:master Dec 1, 2017

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
@rsandell

This comment has been minimized.

Copy link
Member

commented Dec 1, 2017

Was there a Jira ticket for this issue?

@Jimilian

This comment has been minimized.

Copy link
Contributor Author

commented Dec 1, 2017

Sorry, did not find. Should I create one?

@Jimilian Jimilian deleted the Jimilian:fix_wrong_poll_time branch Dec 1, 2017

@rsandell

This comment has been minimized.

Copy link
Member

commented Dec 4, 2017

Nah, not needed after the fact. It just looks better in the changelog to refer to a ticket with hopefully better bug information than a title and code speak on a pr.
And I also wanted to know if there was a ticket that needed to be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.