Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce memory usage #337

Merged
merged 1 commit into from Dec 6, 2017

Conversation

Projects
None yet
2 participants
@Jimilian
Copy link
Contributor

commented Dec 5, 2017

Taking the full name of project from Jenkins leads to string duplication
problem as well as involves recursion. So, it's better to limit the
number of requests to Jenkins Core API as much as possible.

public boolean isProject(Job other) {
if (this.project != null && other != null) {
return this.project.equals(other.getFullName());
public boolean isProject(String otherName) {

This comment has been minimized.

Copy link
@rsandell

rsandell Dec 6, 2017

Member

the original signature can still be kept and deprecated, don't want to break any scripts or other unknown integrations if we can avoid it.

* @return true if it is so.
*/
public boolean equals(Run aBuild) {

This comment has been minimized.

Copy link
@rsandell

rsandell Dec 6, 2017

Member

please keep original signature and deprecate

* @return true if it is so.
*/
public boolean equals(Job aProject) {

This comment has been minimized.

Copy link
@rsandell

@Jimilian Jimilian force-pushed the Jimilian:memory_improvement branch from 7d9ef5b to 03094b5 Dec 6, 2017

Reduce memory usage
Taking the full name of project from Jenkins leads to string duplication
problem as well as involves recursion. So, it's better to limit the
number of requests to Jenkins Core API as much as possible.

@Jimilian Jimilian force-pushed the Jimilian:memory_improvement branch from 03094b5 to 789c82a Dec 6, 2017

@Jimilian

This comment has been minimized.

Copy link
Contributor Author

commented Dec 6, 2017

@rsandell Done

@rsandell rsandell merged commit 1aeb2a7 into jenkinsci:master Dec 6, 2017

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details

@Jimilian Jimilian deleted the Jimilian:memory_improvement branch Dec 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.