Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Check that server is not null before doing the check #342
During Jenkins initialization it's possible to hit the case when GerritMissedEventsPlaybackEnabledChecker is already ready and scheduled, but GerritServer construction is not finished yet.
It leads to something really scare:
Jan 09, 2018 6:57:24 AM hudson.model.AsyncPeriodicWork$1 run INFO: Started GerritMissedEventsPlaybackEnabledChecker Jan 09, 2018 6:57:24 AM hudson.init.impl.InstallUncaughtExceptionHandler$DefaultUncaughtExceptionHandler uncaughtException SEVERE: A thread (GerritMissedEventsPlaybackEnabledChecker thread/201) died unexpectedly due to an uncaught exception, this may leave your Jenkins in a bad way and is usually indicative of a bug in the code. java.lang.NullPointerException at com.sonyericsson.hudson.plugins.gerrit.trigger.playback.GerritMissedEventsPlaybackEnabledChecker.execute(GerritMissedEventsPlaybackEnabledChecker.java:71) at hudson.model.AsyncPeriodicWork$1.run(AsyncPeriodicWork.java:101) at java.lang.Thread.run(Thread.java:748)
p.s. Happy New Year @rsandell! And thank you for maintaining this plugin and your help with getting things done :)