Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-48943] - Whitelist java.util.Collections entries required by the plugin #343

Merged
merged 4 commits into from Jan 15, 2018

Conversation

Projects
None yet
4 participants
@oleg-nenashev
Copy link
Member

commented Jan 15, 2018

oleg-nenashev added some commits Jan 15, 2018

@reviewbybees

This comment has been minimized.

Copy link

commented Jan 15, 2018

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@oleg-nenashev

This comment has been minimized.

Copy link
Member Author

commented Jan 15, 2018

@rsandell I cannot setup CI which would verify 2.102, but I confirm that the plugin appears to be fixed after this patch. Would be great to ship it

@rsandell rsandell merged commit f461672 into jenkinsci:master Jan 15, 2018

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
@@ -1,5 +1,6 @@
buildPlugin(
platforms: ['linux'],
jenkinsVersions: [null],

This comment has been minimized.

Copy link
@jglick

jglick Jan 15, 2018

Member

Why? That is the default.

This comment has been minimized.

Copy link
@oleg-nenashev

oleg-nenashev Jan 15, 2018

Author Member

It is a part of my fiasco with Jenkinsfiling tests against 2.102. Maybe we need to update the blogpost, it does not really work in several plugins due to Maven Enforcer. The blogpost should suggest a flag for disabling it

@@ -0,0 +1,3 @@
# Remove once https://github.com/jenkinsci/jenkins/pull/3234 is integrated?

This comment has been minimized.

Copy link
@jglick

jglick Jan 15, 2018

Member

link to this PR for convenience

@oleg-nenashev

This comment has been minimized.

Copy link
Member Author

commented Jan 15, 2018

Should be replaced once jenkinsci/jenkins#3234 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.