Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allocate new array to perform event processing #355

Merged
merged 1 commit into from Feb 20, 2018

Conversation

Projects
None yet
2 participants
@Jimilian
Copy link
Contributor

commented Feb 15, 2018

Also both getters return unmodifiableList to prevent API misusing.

Do not allocate new array to perform event processing
Also both getters return unmodifiableList to prevent API misusing.
*/
private Iterator<GerritProject> getAllGerritProjectsIterator() {
if (gerritProjects != null && dynamicGerritProjects != null) {
return Iterators.concat(gerritProjects.iterator(), dynamicGerritProjects.iterator());

This comment has been minimized.

Copy link
@rsandell

rsandell Feb 20, 2018

Member

I am normally opposed to using guava, but in this case it's using something existing from Jenkins core so it should be fine.

@rsandell rsandell merged commit e3e44c8 into jenkinsci:master Feb 20, 2018

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details

@Jimilian Jimilian deleted the Jimilian:iterator_gerrit_trigger branch Feb 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.