Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autogenerated prefix to the jenkins-gerrit-trigger tag #366

Merged
merged 1 commit into from Jul 10, 2018

Conversation

Projects
None yet
4 participants
@davido
Copy link
Contributor

commented Jun 20, 2018

This is needed for the comments to be recognized as bot comments on
the Gerrit UI side, see: [1] for more details and the current code: [2].

[1] https://bugs.chromium.org/p/gerrit/issues/detail?id=6357
[2] https://gerrit.googlesource.com/gerrit/+/master/polygerrit-ui/app/elements/change/gr-message/gr-message.js#173

@gertvdijk

This comment has been minimized.

Copy link

commented Jun 20, 2018

Looks OK, cool! (Only nit is commit message typo)

@davido

This comment has been minimized.

Copy link
Contributor Author

commented Jun 20, 2018

(Only nit is commit message typo)

Yes, noticed it, just wonder, how can I edit commit message on GitHub in browser?

@gertvdijk

This comment has been minimized.

Copy link

commented Jun 20, 2018

how can I edit commit message on GitHub in browser?

Last time I checked, GitHub (and siblings) are plain ignorant about commit messages. I couldn't even comment on it. 🤷‍♂

@davido

This comment has been minimized.

Copy link
Contributor Author

commented Jun 20, 2018

Last time I checked, GitHub (and siblings) are plain ignorant about commit messages. I couldn't even comment on it.

Yeah, in Gerrit I could do that. 😃

Add autogenerated prefix to the jenkins-gerrit-trigger tag
This is needed for the comments to be recognized as bot comments on
the Gerrit UI side, see: [1] for more details and the current code: [2].

[1] https://bugs.chromium.org/p/gerrit/issues/detail?id=6357
[2] https://gerrit.googlesource.com/gerrit/+/master/polygerrit-ui/app/elements/change/gr-message/gr-message.js#173

@davido davido force-pushed the davido:patch-1 branch from a84d1ac to f41e7b0 Jun 21, 2018

@davido

This comment has been minimized.

Copy link
Contributor Author

commented Jun 21, 2018

(Only nit is commit message typo)

Should be fixed now. Done.

@rsandell rsandell merged commit d15a6ae into jenkinsci:master Jul 10, 2018

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details

@davido davido deleted the davido:patch-1 branch Jul 10, 2018

@gertvdijk gertvdijk referenced this pull request Aug 8, 2018

Open

Toggle CI Comments #240

@vlotorev

This comment has been minimized.

Copy link

commented Aug 16, 2018

Hi, any chance to release plugin so Jenkins could be updated with this functionality? Without this pull request new PolyGerrit UI on 2.15 doesn't filter out Jenkins comments, so users have to use GWT old UI for now.

It seems last release was half a year ago.

@gertvdijk

This comment has been minimized.

Copy link

commented Aug 16, 2018

@vlotorev You just posted this in the context of a pull request — I suggest to file an issue in the Jenkins issue tracker (component gerrit-trigger-plugin, project 'Jenkins') to request a release instead. Perhaps cc rsandell there.

@vlotorev

This comment has been minimized.

Copy link

commented Aug 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.