Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null check getConfigXml() #369

Merged
merged 1 commit into from Aug 23, 2018

Conversation

Projects
None yet
4 participants
@TheMatthew
Copy link

commented Jul 26, 2018

The contract states it is @checknull. Make code check null.

Null check getConfigXml()
The contract states it is @checknull. Make code check null.
@oswcab
Copy link

left a comment

Use logger built-in formatter as done in other places in this class:

logger.warn("Deleting {}", config.getFile().getAbsolutePath());

logger.error("XML {} is null, please check file permissions.", serverName);

@rsandell rsandell merged commit 0a540e5 into jenkinsci:master Aug 23, 2018

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.