Assure the connection get closed after check #375
On Thu, 30 Aug 2018, 17:41 Robert Sandell, ***@***.***> wrote: ***@***.**** approved this pull request. Though if possible it should be converted to a try with resource expression instead now that we have java 7 as the language level.
Do we? As far as I could see when I was checking yesterday, the level is still configured as 6, and I didn't see any other try with resource in the code. —…
You are receiving this because you commented. Reply to this email directly, view it on GitHub <#375 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAzDStN7YDuav7hP_TOqMxZRyn8tkZjjks5uV6UugaJpZM4WQCNa> .
I checked again and the
and the README still says "Java 6 runtime compatible", so I don't think we can use
Or is the README and pom.xml out of date?
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews.