Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix the synchronisation block in gerritEvent() #382
In GerritMissedEventsPlaybackManager there is gerritEvent method with a block that synchronizes on the receivedEventCache field. It will get a lock on the referenced object that might be changed in line 322. That means that the lock might not work as expected.
Running SpotBugs on the class reveals this problem.