Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make filtering out gerrit user's comments configurable #384

Merged
merged 3 commits into from Dec 18, 2018

Conversation

Projects
None yet
2 participants
@olofek
Copy link
Contributor

commented Oct 3, 2018

It may be useful, as it was for my team, to be able to trigger builds on comments from any user. That is currently not possible since filtering out the Gerrit user's comments is hardcoded.

This change makes that behaviour configurable, with the old behaviour the default.

olofek added some commits Oct 3, 2018

Make filtering out gerrit user's comments configurable
The plugin was hardcoded to filter out comments from the user used to
connect to Gerrit.  Now this is configurable.  The connection needs to
be restarted for changes to this setting to be applied.

Change-Id: I1afb891d5ffd64c5fb4b6bd760a7c322f376f124
Merge branch 'master' into SIST-482
Change-Id: Ief1d3357c30d50f604ebea5758770b3f00893b90
@rsandell
Copy link
Member

left a comment

Sorry for being slow on reviewing. It looks OK. Just holding off with merging until we know if we want to add some more info on the help page or if you think it's enough.
I think it's good to have as much information about a toggle as possible for what it means, but you could argue that there is such a thing as too much information :)

Olof Ekedahl
Add warning about possible performance degradation
Change-Id: Ieba785fb1ba453a670a52ef5fa65b5519b0af85e
@olofek

This comment has been minimized.

Copy link
Contributor Author

commented Dec 12, 2018

Not sure if I'm missing something, but the CI job isn't starting. Has been pending for almost two weeks now.

@olofek olofek closed this Dec 13, 2018

@olofek olofek reopened this Dec 13, 2018

@rsandell rsandell merged commit 91dfd27 into jenkinsci:master Dec 18, 2018

1 check was pending

continuous-integration/jenkins/pr-merge This commit is scheduled to be built
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.