Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java 8 and dependencies changes #390

merged 13 commits into from Jan 31, 2019


None yet
2 participants
Copy link

commented Jan 24, 2019

  • This started with me forking already open PR-389, but GitHub is refusing to let me contribute to that.

What's here?

  • An up to date list of the pipeline ( workflow ) plugins , along with their various dependencies

  • An update to the minimum version of Jenkins, which was necessary when I picked up the new Pipeline plugins

  • Importing of the restructured org.apache.sshd.server.SshServer stuff, along with the related code changes

Florian Ramillien and others added some commits Jan 2, 2019

Florian Ramillien
Move to java 8
Use last Jenkins plugin pom parent version
Do minimal dependencies update
Do some code changes for compatibility with newer dependencies versions
Florian Ramillien
Upgrade Jenkins Core to 2.14 and use AutoCloseable ACL's
+ some fixes for new Jenkins core compatibility
Florian Ramillien
Upgrade Jenkins core to 2.60
- Needed for explicit Java 8 requirement
- Fix NPE in doCheckDependencyJobsNames
- Fix ssh connection in tests (Replace DSA by RSA)
  Security error due to SHA1 use with too short keysize

@rsandell rsandell changed the title WIP: PR-389, plus dependencies changes, sshd fixups Java 8 and dependencies changes Jan 31, 2019

Matrix auth should be in test dependency
And removed a commented import statement
Copy link
Contributor Author

left a comment

A couple more commented-out lines that I found once my brain became fixated on it...

@@ -26,7 +26,7 @@
import com.sonyericsson.hudson.plugins.gerrit.trigger.GerritServer;
import com.sonyericsson.hudson.plugins.gerrit.trigger.PluginImpl;
import hudson.util.TimeUnit2;
// import hudson.util.TimeUnit2;

This comment has been minimized.

Copy link

kshultzCB Jan 31, 2019

Author Contributor

Need to remove this commented out import

HtmlPage confirmPage = j.submit(form);
j.submit(getFormWithAction("doRename", confirmPage.getForms()));
//j.submit(getFormWithAction("doRename", confirmPage.getForms()));

This comment has been minimized.

Copy link

kshultzCB Jan 31, 2019

Author Contributor

Safe to remove these two lines?

@rsandell rsandell merged commit 57bc2a0 into jenkinsci:master Jan 31, 2019

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good

@rsandell rsandell deleted the kshultzCB:pr-389-plus-deps-changes branch Jan 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.