Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-68181]-FIX: Use SafeTimerTask instead of TimerTask for DynamicTriggerConfigU… #463

Conversation

chenhuahuan
Copy link
Contributor

@chenhuahuan chenhuahuan commented Apr 2, 2022

…RL update

I have created an issue on jenkins jira and describes what problem that we met, and provide some useful logging information. For periodical Dynamic Trigger Configure URL updating, it's better use the wrapped SafeTImerTask instead TimerTask.

More detail please refers to jira: https://issues.jenkins.io/browse/JENKINS-68181

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@rsandell rsandell added the bug label Apr 6, 2022
@rsandell
Copy link
Member

rsandell commented Apr 6, 2022

The failing test is a known error that I am trying to fix.

@chenhuahuan
Copy link
Contributor Author

Could you please help to fix the github CI test, please. Hope this PR be merging into next release :)

@rsandell rsandell merged commit b7254ba into jenkinsci:master Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants