Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-48950] [JEP-200] Stop trying to serialize github-api types #616

Merged
merged 1 commit into from Jan 21, 2018
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

@@ -30,13 +30,13 @@

private final URL url;

private final GHUser triggerSender;
private final transient GHUser triggerSender;

This comment has been minimized.

Copy link
@jglick

jglick Jan 17, 2018

Author Member

Note: as mentioned in JIRA, this will still cause problems for loading historical builds (predating this fix and Jenkins 2.102). Probably solvable simply by renaming the fields—but untested.


private final String commentBody;

private final GitUser commitAuthor;
private final transient GitUser commitAuthor;

private final GHUser pullRequestAuthor;
private final transient GHUser pullRequestAuthor;

private final String description;

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.