Skip to content
Permalink
Browse files

[JENKINS-21520] transient NoClassDefFoundError: javax/servlet/Servlet…

…Exception
  • Loading branch information...
ndeloof committed Jul 9, 2015
1 parent 886a322 commit 03409a462896c5c5cd118a88a9e4718c39f605df
Showing with 8 additions and 3 deletions.
  1. +8 −3 src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java
@@ -9,7 +9,6 @@
import edu.umd.cs.findbugs.annotations.NonNull;
import hudson.EnvVars;
import hudson.FilePath;
import hudson.Functions;
import hudson.Launcher;
import com.google.common.collect.Lists;
import hudson.Launcher.LocalLauncher;
@@ -79,7 +78,7 @@
private StandardCredentials defaultCredentials;

private void warnIfWindowsTemporaryDirNameHasSpaces() {
if (!Functions.isWindows()) {
if (isWindows()) {
return;
}
String[] varsToCheck = {"TEMP", "TMP"};
@@ -644,7 +643,7 @@ public ObjectId revParse(String revName) throws GitException, InterruptedExcepti
* See https://github.com/msysgit/msysgit/issues/36 where I filed this as a bug to msysgit.
**/
private String sanitize(String arg) {
if (Functions.isWindows())
if (isWindows())
arg = '"'+arg+'"';
return arg;
}
@@ -2530,4 +2529,10 @@ private String getGitCredentialsURL(URIish u, StandardCredentials cred) {
* best to avoid git interactively asking for credentials, there are many of other cases where git may hang.
*/
public static final int TIMEOUT = Integer.getInteger(Git.class.getName() + ".timeOut", 10);

private boolean isWindows() {
return File.pathSeparatorChar != ';';
}


}

0 comments on commit 03409a4

Please sign in to comment.
You can’t perform that action at this time.