Skip to content
Browse files

Add [JENKINS-46054] integration test

Prior to the fix, this test fails on command line git but passes
on JGit.

After the fix, the test passes on both implementations.
  • Loading branch information
MarkEWaite committed Nov 18, 2017
1 parent 725a9ac commit 81392eda3c65e023d82ca69221070c080128cd26
Showing with 49 additions and 0 deletions.
  1. +49 −0 src/test/java/org/jenkinsci/plugins/gitclient/
@@ -16,6 +16,7 @@
import java.nio.charset.Charset;
import java.nio.file.Files;
import java.nio.file.Paths;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collection;
@@ -1437,6 +1438,54 @@ public void testSubmodulesUsedFromOtherBranches() throws Exception {
assertSubmoduleStatus(gitClient, true, "firewall", "ntp", "sshkeys"); // newDirName module won't be there

public void testSubmoduleUrlEndsWithDotUrl() throws Exception {
// Create a new repository that includes ".url" in directory name
File baseDir = tempFolder.newFolder();
File urlRepoDir = new File(baseDir, "my-submodule.url");
assertTrue("Failed to create URL repo dir", urlRepoDir.mkdir());
GitClient urlRepoClient = Git.with(TaskListener.NULL, new EnvVars()).in(urlRepoDir).using(gitImplName).getClient();
File readme = new File(urlRepoDir, "readme");
String readmeText = "This repo includes .url in its directory name (" + random.nextInt() + ")";
Files.write(Paths.get(readme.getAbsolutePath()), readmeText.getBytes());
urlRepoClient.commit("Added README to repo used as a submodule");

// Add new repository as submodule to repository that ends in .url
File repoHasSubmodule = new File(baseDir, "has-submodule.url");
assertTrue("Failed to create repo dir that will have submodule", repoHasSubmodule.mkdir());
GitClient repoHasSubmoduleClient = Git.with(TaskListener.NULL, new EnvVars()).in(repoHasSubmodule).using(gitImplName).getClient();
File hasSubmoduleReadme = new File(repoHasSubmodule, "readme");
String hasSubmoduleReadmeText = "Repo has a submodule that includes .url in its directory name (" + random.nextInt() + ")";
Files.write(Paths.get(hasSubmoduleReadme.getAbsolutePath()), hasSubmoduleReadmeText.getBytes());
repoHasSubmoduleClient.commit("Added README to repo that will include a submodule whose URL ends in '.url'");
String moduleDirBaseName = "module.named.url";
File modulesDir = new File(repoHasSubmodule, "modules");
assertTrue("Failed to create modules dir in repoHasSubmodule", modulesDir.mkdir());
repoHasSubmoduleClient.addSubmodule(repoHasSubmodule.getAbsolutePath(), "modules/" + moduleDirBaseName);
repoHasSubmoduleClient.commit("Add modules/" + moduleDirBaseName + " as submodule");
assertSubmoduleStatus(repoHasSubmoduleClient, true, moduleDirBaseName);

// Clone repoHasSubmodule to new repository with submodule
File cloneDir = new File(baseDir, "cloned-submodule");
assertTrue("Failed to create clone dir", cloneDir.mkdir());
GitClient cloneGitClient = Git.with(TaskListener.NULL, new EnvVars()).in(cloneDir).using(gitImplName).getClient();
String branch = "master";
cloneGitClient.checkoutBranch(branch, "origin/" + branch);
assertSubmoduleStatus(cloneGitClient, true, moduleDirBaseName);

public void testGetSubmodules() throws Exception {
assumeThat(gitImplName, is("git")); // JGit implementation doesn't handle renamed submodules

0 comments on commit 81392ed

Please sign in to comment.