Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-35687] Add simple git lfs support #206

Closed
wants to merge 1 commit into from

Conversation

@matthauck
Copy link
Contributor

commented Jun 14, 2016

No description provided.

@MarkEWaite

This comment has been minimized.

Copy link
Contributor

commented Jun 14, 2016

I'd really like some form of automated tests to be included with the pull request. Without automated tests, we then must rely on the plugin developer to interactively test this feature before every plugin release.


if (withLFS) {
ArgumentListBuilder lfsArgs = new ArgumentListBuilder();
lfsArgs.add("lfs");

This comment has been minimized.

Copy link
@MarkEWaite

MarkEWaite Jun 14, 2016

Contributor

Wouldn't it be better to check that LFS is available in the git version being used, rather than just throw an exception when it fails?

This comment has been minimized.

Copy link
@matthauck

matthauck Jun 14, 2016

Author Contributor

Since it is an explicit setting that one would turn on, it makes most sense to me to just fail if it isn't present, rather than just log it and continue the build (which will mostly likely fail in some not-well-defined way, when it, for example, tries to extract a zip file that is not a zip file since lfs).

If you would rather thIs do a check, is there a pattern in the git client plugin I can reference for checking for git feature support?

@matthauck

This comment has been minimized.

Copy link
Contributor Author

commented Jun 14, 2016

Wasn't quite sure how to add an automated test that did not require having git lfs installed and have something to fetch... Or maybe there is a mock cli that you have setup that can just check if commands were run?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.