Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[JENKINS-40834] Add an API to resolve symbolic refs #236
(Downstream PR for git-plugin to use the API will follow - based on WIP in https://github.com/jenkinsci/git-plugin/tree/jenkins-40834 that needed this change to have a hope of working)
@MarkEWaite I have reworked this somewhat based on your feedback.
Now the API will return an empty map if the client or remote server does not support symref reporting.
Consumers will have to decide what they want to do in the absence of the symref information, which I think is better than trying to fake out the information in the Git 1.8.4 way
@stephenc , I think this is ready to merge, so long as you are OK with me adding the changes I've implemented in https://github.com/MarkEWaite/git-client-plugin/commits/master-PR236-resolve-symbolic-refs . I'd merge this to the master branch, then squash my changes into a more coherent set of a few commits and merge them to the master branch.
Is that OK with you, or would you prefer to make changes based on my last review?
I've confirmed that the tests pass on CentOS 6 (git 1.7.1), CentOS 7 (git 188.8.131.52) , Debian 7 (git 184.108.40.206), Debian 8 (git 2.1.4), Ubuntu 14 (git 1.9.1), Ubuntu 16 (git 2.1.4), Ubuntu 16 with the latest ppa (git 2.11), and windows (git 2.12.1).