Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-52948] Convert anonymous MasterToSlaveFileCallable to member #330

Merged
merged 1 commit into from Jul 7, 2018

Conversation

Projects
None yet
3 participants
@jsoref
Copy link
Contributor

jsoref commented Jul 6, 2018

org.jenkinsci.remoting.util.AnonymousClassWarnings warn:

WARNING: Attempt to (de-)serialize anonymous class org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1
WARNING: Attempt to (de-)serialize anonymous class org.jenkinsci.plugins.gitclient.Git$1

see: https://jenkins.io/redirect/serialization-of-anonymous-classes/

https://issues.jenkins-ci.org/browse/JENKINS-50457

Convert anonymous MasterToSlaveFileCallable to member
org.jenkinsci.remoting.util.AnonymousClassWarnings warn:

WARNING: Attempt to (de-)serialize anonymous class org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1
WARNING: Attempt to (de-)serialize anonymous class org.jenkinsci.plugins.gitclient.Git$1

see: https://jenkins.io/redirect/serialization-of-anonymous-classes/

@MarkEWaite MarkEWaite requested review from jeffret-b and oleg-nenashev Jul 6, 2018

@oleg-nenashev
Copy link
Member

oleg-nenashev left a comment

Harmless and helpful so 👍 .
@jsoref you may need to refactor half of Jenkins plugins to fix this issue everywhere :(

@MarkEWaite MarkEWaite merged commit ab12cf2 into jenkinsci:master Jul 7, 2018

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
@jsoref

This comment has been minimized.

Copy link
Contributor Author

jsoref commented Jul 8, 2018

@oleg-nenashev it's forcing me to appreciate IntelliJ...

@jsoref jsoref deleted the jsoref:anonymous-mastertoslavecallable branch Jul 8, 2018

@jglick jglick changed the title Convert anonymous MasterToSlaveFileCallable to member [JENKINS-52948] Convert anonymous MasterToSlaveFileCallable to member Aug 30, 2018

@MarkEWaite MarkEWaite added this to the 3.0 milestone Dec 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.