New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-20445] [JENKINS-20387] [JENKINS-20750] #92
Conversation
Expose timeout for clone and fetch command when using CliGit
plugins » git-client-plugin #272 SUCCESS |
It seems it will be hard to get JGit to offer equivalent support for git related tasks, even without considering advanced usages. |
I wonder: why don't you just set a higher timeout using system property ? |
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
We set up almost all of our jobs with the Job DSL plugin. This makes it On Fri, Jan 31, 2014 at 5:37 PM, Nicolas De loof
|
ok, then the main question is to know if more than 10 minutes for a git clone is reasonable, and considered a good usage of git. |
A 10 minute git clone is "reasonable" for the many people (like me) who've made the mistake of placing large binaries into a local git repository, or the other people who are performing a git clone over a very slow link. The mailing list has included several mail messages (and several bug reports) requesting that the timeout be available for modification by the user. I think this is a good enhancement to include for those users (like me) who often must deal with large git repositories or slow links. The current msysgit implementation of ssh limits the transfer rate to less than 1.5 MB/second due to the old version of OpenSSH which is included in msysgit. Even with a fast local area network, mssygit cannot clone an ssh protocol repository larger than 900 MB within the 10 minute timeout period. That same limit does not exist on Unix variants, and does not exist for git protocol on msysgit, but those users who are required to use ssh to clone their repository are rate limited on Windows. I recommend accepting the addition. I assume someone has tested it for upgrade compatibility. |
I built a copy of this submission and built a copy of the matching submission to git-plugin and ran some simple tests to confirm the timeout was being honored while cloning. With the timeout at 2 minutes, the clone failed because the timeout was reached. With the timeout at 4 minutes, the clone worked. I recommend including this change and the matching change to git-plugin in the next release of the two plugins. |
Yes, will do. Thanks a lot for testing it.
|
Expose timeout for clone and fetch command when using CliGit