Skip to content
Permalink
Browse files

[JENKINS-34350] Add test for crumb exclusion on /git/notifyCommit

  • Loading branch information...
liskin committed Apr 27, 2017
1 parent 8ac8cc9 commit 509e137bda520ccba3032ed66a08e5f7be2b5c45
Showing with 59 additions and 0 deletions.
  1. +59 −0 src/test/java/hudson/plugins/git/GitStatusCrumbExclusionTest.java
@@ -0,0 +1,59 @@
package hudson.plugins.git;

import hudson.security.csrf.CrumbFilter;

import org.junit.Before;
import org.junit.Rule;
import org.junit.Test;

import javax.servlet.FilterChain;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;

import java.util.Collections;

import static org.mockito.Matchers.*;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.never;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;

import org.jvnet.hudson.test.JenkinsRule;

public class GitStatusCrumbExclusionTest {

@Rule
public JenkinsRule r = new JenkinsRule();

private CrumbFilter filter;
private HttpServletRequest req;
private HttpServletResponse resp;
private FilterChain chain;

@Before
public void before() {
filter = new CrumbFilter();
req = mock(HttpServletRequest.class);
resp = mock(HttpServletResponse.class);
chain = mock(FilterChain.class);
}

@Test
public void testNotifyCommit() throws Exception {
when(req.getPathInfo()).thenReturn("/git/notifyCommit");
when(req.getMethod()).thenReturn("POST");
when(req.getParameterNames()).thenReturn(Collections.<String>emptyEnumeration());
filter.doFilter(req, resp, chain);
verify(resp, never()).sendError(anyInt(), anyString());
}

@Test
public void testInvalidPath() throws Exception {
when(req.getPathInfo()).thenReturn("/git/somethingElse");
when(req.getMethod()).thenReturn("POST");
when(req.getParameterNames()).thenReturn(Collections.<String>emptyEnumeration());
filter.doFilter(req, resp, chain);
verify(resp, times(1)).sendError(anyInt(), anyString());
}
}

0 comments on commit 509e137

Please sign in to comment.
You can’t perform that action at this time.