[JENKINS-43507] Documenting GitSCMBuilder

jenkinsci · May 2, 2017 · 7c2ba1bc4f91a89e97d8ef5916c56fbcb7992d3d · 7c2ba1b
1 parent 3c3336e
commit 7c2ba1bc4f91a89e97d8ef5916c56fbcb7992d3d
Unified Split

Showing with 296 additions and 97 deletions.

+3 −5 src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java

+293 −92 src/main/java/jenkins/plugins/git/GitSCMBuilder.java
diff --git a/src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java b/src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java
@@ -617,15 +617,13 @@ protected StandardUsernameCredentials getCredentials() {
    }
    protected GitSCMBuilder newBuilder(@NonNull SCMHead head, @CheckForNull SCMRevision revision) {
-  
-        return new GitSCMBuilder(head, revision);
+  
+        return new GitSCMBuilder(head, revision, getRemote(), getCredentialsId());
    }
    @NonNull
    @Override
    public SCM build(@NonNull SCMHead head, @CheckForNull SCMRevision revision) {
-  
-        GitSCMBuilder builder = newBuilder(head, revision)
-  
-                .withRemote(getRemote())
-  
-                .withCredentials(getCredentialsId());
+  
+        GitSCMBuilder builder = newBuilder(head, revision);
        if (Util.isOverridden(AbstractGitSCMSource.class, getClass(), "getExtensions")) {
            builder.withExtensions(getExtensions());
        }
@@ -640,7 +638,7 @@ public SCM build(@NonNull SCMHead head, @CheckForNull SCMRevision revision) {
            for (RefSpec spec: getRefSpecs()) {
                specs.add(spec.toString());
            }
-  
-            builder.withRefSpecs(specs);
+  
+            builder.withoutRefSpecs().withRefSpecs(specs);
        }
        return builder.withTraits(getTraits()).build();
    }