Skip to content
Permalink
Browse files

Fix JENKINS-33695 by reverting "Fix GitSCM findbugs serialization war…

…nings"

This reverts commit bb6f686 and fixes
JENKINS-33695. The serialization of extensions is critical to preserving
the settings when saving the job.

Most embarrassing that my interactive testing prior to release of git
plugin 2.4.3 did not detect the problem.
  • Loading branch information
MarkEWaite committed Mar 23, 2016
1 parent 8bb7927 commit 7f21ab8da120d285b81a07a33fbe2ad54965fa9d
Showing with 3 additions and 4 deletions.
  1. +3 −4 src/main/java/hudson/plugins/git/GitSCM.java
@@ -126,7 +126,7 @@
/**
* All the configured extensions attached to this.
*/
private transient DescribableList<GitSCMExtension,GitSCMExtensionDescriptor> extensions;
private DescribableList<GitSCMExtension,GitSCMExtensionDescriptor> extensions;

public Collection<SubmoduleConfig> getSubmoduleCfg() {
return submoduleCfg;
@@ -893,9 +893,8 @@ public String getGitExe(Node builtOn, EnvVars env, TaskListener listener) {
}

/*package*/ static class BuildChooserContextImpl implements BuildChooserContext, Serializable {
private static final long serialVersionUID = 1L;
final transient Job project;
final transient Run build;
final Job project;
final Run build;
final EnvVars environment;

BuildChooserContextImpl(Job project, Run build, EnvVars environment) {

0 comments on commit 7f21ab8

Please sign in to comment.
You can’t perform that action at this time.